Skip to content

🖼️ Show images in message notifications#5909

Merged
AndyScherzinger merged 5 commits intomasterfrom
feat/2300/imagesInNotifications
Mar 3, 2026
Merged

🖼️ Show images in message notifications#5909
AndyScherzinger merged 5 commits intomasterfrom
feat/2300/imagesInNotifications

Conversation

@AndyScherzinger
Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger commented Feb 26, 2026 •
edited
Loading

🖼️ Screenshots

Home Collapsed Expanded
home collapsed expanded

🚧 TODO

  • discuss hardening

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added this to the 23.1.0 milestone Feb 26, 2026
@AndyScherzinger AndyScherzinger added enhancement New feature or request 2. developing Work in progress discussion Being discussed feature: notifications 🔔 labels Feb 26, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/2300/imagesInNotifications branch from b573139 to 280bedb Compare February 27, 2026 00:01
@AndyScherzinger AndyScherzinger added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 27, 2026
@AndyScherzinger AndyScherzinger force-pushed the feat/2300/imagesInNotifications branch from 280bedb to d61c875 Compare February 28, 2026 08:49
mahibi
mahibi requested changes Mar 2, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A collapsed notification that contains an image currently looks like

Image

(Android 16)

So there is the person placeholder shown. I would expect a tiny preview of the image instead.

@AndyScherzinger
feat: Show images in message notifications
dd1082c 
Resolves #2300

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style(detekt): extract business logic to comply with detekt rules
4d01d34 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
style: use descriptive method names
9204796 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
fix: Set preview width based on device width in pixel
267ddc6 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/2300/imagesInNotifications branch from d61c875 to cfa5578 Compare March 2, 2026 17:08
@AndyScherzinger
style: Show image in collapse notification as small icon value
26a9d25 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the feat/2300/imagesInNotifications branch from cfa5578 to 26a9d25 Compare March 2, 2026 17:12
@AndyScherzinger AndyScherzinger requested a review from mahibi March 2, 2026 17:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2026

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/5909.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 2, 2026

Codacy

Lint

TypemasterPR
Warnings9898
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5454
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8181

mahibi
mahibi approved these changes Mar 3, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine 👍

@AndyScherzinger AndyScherzinger merged commit e4b16ca into master Mar 3, 2026
18 checks passed
@AndyScherzinger AndyScherzinger deleted the feat/2300/imagesInNotifications branch March 3, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mahibi mahibi mahibi approved these changes

Assignees

No one assigned

Labels

3. to review Waiting for reviews discussion Being discussed enhancement New feature or request feature: notifications 🔔

Projects

None yet

Milestone

24.0.0

Development

Successfully merging this pull request may close these issues.

The ability to preview media such as images in the android notification tray.

2 participants

@AndyScherzinger @mahibi